TheStarport / FLHook

A Server Improvement for Freelancer.
GNU General Public License v3.0
30 stars 15 forks source link

Total conversion of all strings in the codebase to wstring or handle conversions of string to wtstring implicitly #336

Closed MrNen closed 1 year ago

MrNen commented 1 year ago

We end up doing a lot of conversion from wstring to string, and it causes a lot of reuse of stows and wstos, and ends up with a bunch of reused code.

We could handle this by making the underlying pub and HK functions handle conversions and take strings, or just remove any reference of string and have the entire codebase exclusively use wstrings.

Lazrius commented 1 year ago

Almost certainly it would be more optimal to work with wstring everywhere. Far more of Freelancer's internal functions work with wstring which will cut down on our total count of conversions

MrNen commented 1 year ago

We have decided to full convert to wstring and is now finished.