Open IrateRedKite opened 7 months ago
I know it was my idea, but now I'm not convinced we would need to generate a dynamic properties file to remain compatible with Forks.
You seem to be able to pass sonar properties to the scanner directly. Presumably it looks up missing ones in the properties file.
So perhaps we could add the repo specific ones here with variables, and just keep the generic ones in the properties file?
In the newest version, manual sonar scanning will no longer be nessasary and our reliance on github actions will be removed. Will leave issue open until 5.0 is merged, but it is currently possible for you to have forks be scanned through the sonar portal (our config may be out of date, not tried)
I was looking at getting SonarCloud set up for our fork of FlHook and found that it's reliant on
sonar-project.properties
.Obviously I'd rather not have to worry about accidentally pushing my version of this to the main branch, so would like to propose a workflow that generates the file using github actions and environment variables instead. Something a bit like:
My knowledge of CI/CD is quite limited, so I'd appreciate it if someone like @Lazrius could take a look and let me know how viable this implementation is.