TheStonedTurtle / Loot-Logger

A RuneLite plugin that stores Loot Tracker data locally
BSD 2-Clause "Simplified" License
6 stars 9 forks source link

Suggestion: Combine player kills into a single category #10

Closed OlavH96 closed 4 years ago

OlavH96 commented 4 years ago

Very nice plugin! Love it for bosses, however I think it would be nice to have player kills as an individual category like bosses are. It currently tracks player kills, however each player becomes its own category, which is not very helpful.

Pictures, current behaviour.

Screenshot from 2020-03-24 00-46-00 Screenshot from 2020-03-24 00-46-10

Desired outcome, like above image, except every player kill instead of just for this player.

Keep up the good work!

TheStonedTurtle commented 4 years ago

Due to the way data is stored the only way to filter by category (PvM vs PvP) would require reading data from each file on load. Adding this would require rewriting the data storage to use a folders for each event type, which would also require writing a migration tool for existing data.

If you have any suggestions for how the UI should show these different categories let me know.

OlavH96 commented 4 years ago

I envision the UI could look something like this, with space for different categories.

Screenshot from 2020-0ssds3-24 17-28-42

I see your log files contain the type: "PLAYER" for player kills, which could be used to migrate these files.

My ad hoc solution would be to load every file when above PvP button is clicked, and keep every file with type: PLAYER in it. Combining the result and passing it to the existing LootPanel UI. I am not very experienced in Runelite development, so I am not sure if this is doable for you.

TheStonedTurtle commented 4 years ago

So i created a system to separate loot by Record Type but now IDK how to display the different categories.

There are events (Like COX, TOB, Barrows, Gauntlet, Herbiboar, etc), pickpockets, NPCs, players, and unknown. I don't think an icon for each category would be a good idea (like your mock up) as those icons are tied to a config option.

Do you think separating them with collapse-able headers below the search bar would be sufficient?

Example Gif (Ordering will be fixed to maintain current functionality) vGs1BZlmgN