search

TheStonedTurtle / banked-experience

A RuneLite plugin used to calculate the experience you have banked
BSD 2-Clause "Simplified" License
15 stars 44 forks source link

Add Perfect Shell to Crafting Items #137

Closed Locotime closed 1 month ago

Locotime commented 7 months ago

Add Perfect Shell to ExperienceItem.java and Activity.java

TheStonedTurtle commented 7 months ago

I appreciate the effort and thought you meant by creating this PR but in the future please do not submit PRs if your code does not compile or run. You should also be testing your code prior to creating a PR.

If you aren't sure how to test this you should read the RL Plugin-Hub documentation, namely step 5: https://github.com/runelite/plugin-hub?tab=readme-ov-file#setting-up-the-development-environment

image

TheStonedTurtle commented 1 month ago

No changes made here in months, closing PR. Feel free to create a new one once the above has been addressed.

TheStonedTurtle commented 1 month ago

Implemented in 764952065562f5bdb8180278b92811db22870da6