search

TheStonedTurtle / banked-experience

A RuneLite plugin used to calculate the experience you have banked
BSD 2-Clause "Simplified" License
15 stars 44 forks source link

Update Activity.java #141

Closed Koslas1 closed 5 months ago

Koslas1 commented 6 months ago

Fixed xp for the cleaned fossils on Fossil island (Was showing 0xp)

TheStonedTurtle commented 6 months ago

These items are setup so that they cascade into the actual item that rewards xp, in this case the normal fossil before cleaning & enriching:

image image

You will see that in the second image we jump up to 102 large fossils instead of 97 large fossils. If you aren't seeing this it's because you do not have this config option enabled: image

If you think this is bad design then we can merge your PR after you remove this cascading feature from the activities:

SMALL_LIMBS(ItemID.SMALL_FOSSILISED_LIMBS, "Small limbs", 1, 500,
    ExperienceItem.SMALL_LIMBS, null, new ItemStack(ItemID.UNIDENTIFIED_SMALL_FOSSIL, 1)),

would change to

SMALL_LIMBS(ItemID.SMALL_FOSSILISED_LIMBS, "Small limbs", 1, 500,
    ExperienceItem.SMALL_LIMBS, null, null),
Koslas1 commented 6 months ago

My apologizes, I didn't see it was working like that, however when editing it I did notice you were calling the same fossil for each item. It wasn't that clear to me that was how it worked, as you'll be able to see it's a bit hard to read my prayer in #142