TheStonedTurtle / banked-experience

A RuneLite plugin used to calculate the experience you have banked
BSD 2-Clause "Simplified" License
15 stars 44 forks source link

Prayer - inconsistencies with choosing which way to use bones creating errors in experience amount. Suggestion: make it consistent. #148

Open Raisoshi opened 5 months ago

Raisoshi commented 5 months ago

So apparently with the addition of blessed bone shards you can switch between bury and bone shards with the dropdown menu, while altar/ecto/offering remains on the checkbox options.

image

Except for wyrmling bones that is.

image

The checkbox options don't apply the XP multiplier to wyrmling bones and you have to manually pick from the dropdown menu for it to work correctly if you're intending to sacrifice those on an altar.

I'd like to suggest the complete removal of the checkbox options and to make the dropdown menu the standard way accross the board, pretty much how it works with Construction. Not only does this save your choices if you leave the Prayer tab, it allows you to customize what you'd like to do with each item.

TheStonedTurtle commented 5 months ago

The checkbox options don't apply the XP multiplier to wyrmling bones and you have to manually pick from the dropdown menu for it to work correctly if you're intending to sacrifice those on an altar.

This inconsistency is because jagex decided to make Wyrmling bones the only bones in game where these methods don't provide the same xp increases.

For example the Lit Gilded Altar should be 300% experience (63) but instead is 73.5 for these bones or 350%. Ecto should be 400% exp (84) but is instead 120xp or ~571% exp bonus.

I'd like to suggest the complete removal of the checkbox options and to make the dropdown menu the standard way accross the board, pretty much how it works with Construction. Not only does this save your choices if you leave the Prayer tab, it allows you to customize what you'd like to do with each item.

Having to manually update every bone type to the method you want is way more effort when I'd say that easily >90% of use cases have people using all their bones with one method. You'd either use Ecto/Gilded (HCIM) or Wildy Altar and will right-click ignore the bones you don't want to use.

I may eventually update the modifiers to work properly for wyrmling bones but that was a bigger lift than doing this and I wanted to get this out ASAP.