TheStonedTurtle / banked-experience

A RuneLite plugin used to calculate the experience you have banked
BSD 2-Clause "Simplified" License
15 stars 44 forks source link

Ancient Essence herblore calculation is incorrect #154

Closed hollyroberts closed 3 weeks ago

hollyroberts commented 3 weeks ago

I recently noticed that I had 10m banked herblore XP all of a sudden. This appears to be due to the ancient essence in my bank screenshot which gives 36xp/action. The wiki page for making forgotten brews says that each dose requires 20 essence, so the xp/action should be 1.8. I believe this issue was introduced here.

Unrelated to the calculation here, as a user I find this choice of primary/secondary to be the wrong way around. I can obtain thousands of essence from Muspah with ease, but ancient brews are difficult and slow. I also passively obtain essence going for venator bow/ancient icon, whereas ancient brews are more of an issue. Nex is done later than Muspah, and even with Nihil dust you need unfinished dwarf weed potions which is a primary for making ancient brews.

TheStonedTurtle commented 3 weeks ago

Fixed in c0373c43a3ffd60cccfde22343bc00575ce9584f