Support for banked secondaries for herblore

[hjdarnel]

Howdy! One improvement I can think of is considering secondaries when calculating banked herblore experience, since your herb xp isn't truly banked unless you have the herbs and the secondaries banked as well. Perhaps some way you could indicate a surplus of secondaries compared to herbs, or vice versa as well?

[TheStonedTurtle]

I've thought about implementing this but it becomes difficult for the skills such as Smithing where a single secondary resource (coal) is used for multiple activities. I could ignore cases like this but then the toggle is sorta useless for that skill, i could prioritize higher leveled activities but maybe that isn't what the player wants.

There's also the issue of how to count multiple items as the same secondary/banked item, which is what has prevented me from adding stamina pots to the calculator. Stamina potions would need to combine all the super energy(1)-(4) doses into a single value since its a 1:1 crystal:dose ratio as well as convert marks of grace into crystals. An argument could be made for stuff like super combats where it uses an existing potion that it should function similarly since you can decant potions at the GE.

Between deciding on how to handle the secondaries being used in multiple places, counting multiple items as the same secondary, and finding a spot inside the UI i just haven't felt it was worth implementing.

Although it requires some work I just withdraw to my secondary limit so my bank is only calculating what i can make at that moment since items in your inventory are ignored from the calculation.

[TheStonedTurtle]

By the way, you can hover over the Secondaries to get a tooltip displaying how much you have.

If you aren't seeing the secondaries check the plugin config.

[hjdarnel]

Gotcha. I understand the complexities of it. I didn’t notice the hover over the secondaries, that’s pretty helpful for my needs! Thanks. You can close this if you want, or keep it open if you think you do want to improve it eventually. Thanks for the plugin :)

On Wed, Jan 15, 2020 at 3:26 PM TheStonedTurtle notifications@github.com wrote:

By the way, you can hover over the Secondaries to get a tooltip displaying how much you have.

[image: https://i.imgur.com/goZHD9D.png] https://camo.githubusercontent.com/b6a25a801ea96070508991bffe531f30b77b3cc9/68747470733a2f2f692e696d6775722e636f6d2f676f5a484439442e706e67

If you aren't seeing the secondaries check the plugin config.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TheStonedTurtle/banked-experience/issues/9?email_source=notifications&email_token=AB4BDY37U2PMESMPZQPPG2DQ555QTA5CNFSM4KHJ4AOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJB3RZA#issuecomment-574863588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4BDY4KZNXT3PM2J5KE5C3Q555QTANCNFSM4KHJ4AOA .

[Budfraiz]

Be cool if the herblore section could spit out a list of total secondaries needed.

[GregTheGreek]

Started chipping away at this, just because I needed a break from work lol.

I think I understand the problem regarding coal, per the screenshot below I think the math for this could work in the same way.

Since we can calculate how much is needed per activity (eg: iron, mith, etc) why not offer two sort options: high and low where high would sort on highest xp earning activity first, and low the inverse. "

I think this is the lowest overhead and shows the true rates for what is banked.

[TheStonedTurtle]

Yeah that could work if you make a new dropdown config option where users can select a secondary experience limiting mode and include none for current behavior & default value and high/low as you recommended.

[GregTheGreek]

cool, I'll see how far I get today.

From an architecture POV, would it make the most sense to just keep everything in SecondaryGrid.java, I'll create some public getter like getSecondaryXp() that would perform a similar calculation to the secondary tooltip?

[TheStonedTurtle]

It depends on how you plan to handle all the UI stuff IMO. What visual indicator will there be that an item can't be used because it's missing secondaries (such as mithril ore if not enough coal). Does the calculator need to be able to calculate both all exp and exp limited by secondaries or should it affect the entire calculator based on whether none or low/high is selected?

But honestly it doesn't really matter, as long as it makes sense where you put it that's fine. Can also make a utility class if you want to, whatever you feel is cleanest.

[GregTheGreek]

@TheStonedTurtle I opened up #125, let me know what you think of the first attempt at it