[Bug] Validation fails when cells have markup

TheSunCat / Sudoku

FOSS Sudoku, made with 💜 (and Flutter).

GNU General Public License v3.0

64 stars 6 forks source link

[Bug] Validation fails when cells have markup #7

Closed novellus closed 2 years ago

novellus commented 2 years ago

A subset of cells with markup are incorrectly labeled as invalid when validation is run. See photo for example. It looks like the intent was to only validate cells with a non-zero value.

Reproduction steps:

Fill every cell with markup (any number[s])
Run validation

Notes

The incorrectly marked cells will re-mark as incorrect if validation is run again after markup is modified, markup removed and readded, or if a value is specified and then changed to markup.
The incorrectly marked cells are not sensitive to the number contents of the markup, but do require at least one number in markup.
The incorrectly marked cells are not invalidated if given a value rather than markup.
The positions and number of incorrectly marked cells changes with each new game, so its possible that some games will have zero incorrectly marked cells.

IMG_20221028_012353

TheSunCat commented 2 years ago

Thanks for the report! I indeed intended to only validate cells that have an actual value input (not annotations), but clearly this is not working. I could try to fix this by force-ignoring all cells that have markup, but unfortunately I can't seem to reproduce this issue. I've created five "Expert" games and filled every fillable cell with a markup, yet no cells are highlighted red when validating. Am I doing this wrong?

novellus commented 2 years ago

Interesting, I just tried as well and got the following results

filled all cells with markup -> validate -> nothing wrong
filled one cell with a number -> validate -> nothing wrong
filled 2nd cell with a number -> validate -> one marked up cell was invalidated
filled 3rd cell with a number -> validate -> two marked up cells were invalidated

The bug probably requires some cells with values.

Note: on this attempt it was clear the invalidated cells were reflections of the cells with values across the diagonal from top-left to lower-right.

TheSunCat commented 2 years ago

Thank you for the additional testing! This looks like the bugged board validation which I fixed with 18d0c3c73f07c59a6400dca9faa00fa56173a15c. I am running a build from source, hence I couldn't reproduce it! The fix should be out on F-Droid in a couple days at most (their build server has to pick up the new tagged release). I will keep this open until we can verify this doesn't happen on the latest F-Droid build.

novellus commented 2 years ago

This bug seems to be fixed in the latest build, marking as closed.