TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
57 stars 19 forks source link

Some infantry animations stutter on injured walk #1039

Open xezon opened 2 years ago

xezon commented 2 years ago

Some infantry animations stutter on injured walk. Most obvious on USA Missile Defender and China Tank Hunter. To fix, W3D animation likely needs more frames.

The stutter amount was just estimated purely by observation.

Object Injured Stutter
Original USA Ranger
Original USA Missile Defender 50%
Original USA Pathfinder
Original USA Burton 20%
Original USA Pilot
Original China Red Guard
Original China Minigunner
Original China Tank Hunter 50%
Original China Lotus
Original China Hacker 33%
Original GLA Rebel
Original GLA Tunnel Defender
Original GLA Terror 20%
Original GLA Hijacker
Original GLA Saboteur
Original GLA Jarmen

https://user-images.githubusercontent.com/4720891/187480028-f5eef76b-e438-44de-b8de-1f419d088760.mp4

fastAiRR commented 1 year ago

I haven't seen it but I'm sure you have it. Infantry being stupid when chasing a guy who is running away. They stop to take aim, but by that time the guy ran off lol. Its countered by telling the guy to run until he is in range and then u manually attack, but that is far more micro time to do that, you either stare at it, or look away and have to come back.

Worker outruns people easy like this.

commy2 commented 1 year ago

~~The issue with the Missile Defender and Tank Hunter may be related to their quirky INI setup. They have AnimationSpeedFactorRange = 0.8 1.2 defined in DefaultConditionState (standing idle), which is inherited by MOVING ConditionState. This means that once the unit starts moving, the walk animation may be played slower or faster than normally. The vast majority of units do play the walk animations at a constant speed. Randomization is done via RANDOMSTART (to make mass moving units look less synchronized).~~

It's not. SpeedFactorRange does not apply to animations with distance modifier defined (such as MOVING for these units).