TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

Make demobikes create an explosion big and powerful enough to destroy other demobikes in close range on death. #138

Open xamorish opened 3 years ago

xamorish commented 3 years ago

This will force the GLA player to not stack demobikes and will give the opposing player's units time to take out bikes one by one and not in large groups, like it is with bomb trucks.

xezon commented 3 years ago

This is a design and balancing question. It certainly is reasonable from a design standpoint to apply some friendly damage. It could behave similar to Nuklear Battlemaster for example. But it changes gameplay expectations.

xamorish commented 3 years ago

This is a design and balancing question. It certainly is reasonable from a design standpoint to apply some friendly damage. It could behave similar to Nuklear Battlemaster for example. But it changes gameplay expectations.

True. It should be decided whether this change in gameplay expectations is for the good. My personal opinion is nerfing demobikes this way should exclude the situation where the question "will i lose or not?" could be also interpreted as "will the enemy GLA player build enough demobikes or not?".

xezon commented 3 years ago

I just tested some demo bikes and they do already apply slash damage to friendly units nearby.

commy2 commented 3 years ago

But not to other Demo Bikes of the same faction, i.e. other Demo General Bikes.

See: before and after Demolitions upgrade.

The NOT_SIMILAR flag.

xezon commented 3 years ago

I do not understand. Meaning it applies no damage to nearby Worker on Bike for example?

MTKing4 commented 3 years ago

This will render demo bikes useless, bomb trucks can take buildings on their own so it makes sense thay they explode in a chain-reaction manner so player can't spam them, demo bikes however can't, they function like a terrorist would not killing themselves in TTs except toxin ones

I'm against this

commy2 commented 3 years ago

I do not understand. Meaning it applies no damage to nearby Worker on Bike for example?

Before the Demolitions upgrade, the Demo General's Demo Bike uses the SuicideBikeBomb weapon when it killed itself.

SuicideBikeBomb affects uses the following RadiusDamageAffects flags:

SELF
SUICIDE
ALLIES
ENEMIES
NEUTRALS
NOT_SIMILAR

SELF and SUICIDE are pointless, since the unit is already dead. ALLIES means the weapon does damage the players own units. However, it also uses the NOT_SIMILAR flag. This means that other Demo General Demo Bikes are not affected by the explosion. This is the case no matter what unit is the rider. However, it would still damage Bikes from other sub-factions, as these are different units.

commy2 commented 3 years ago

After the Demolitions upgrade, the Demo General's Demo Bike with a Terrorist on top only uses the Demo_TerroristOnCombatBikeSuicideDynamitePack when it killed itself, and Demo_TerroristOnCombatBikeSuicideDynamitePackPlusFire when it was killed by something else.

Both of these weapons have ALLIES commented out. Therefore, after the Demolitions upgrade, the Demo General's Demo Bike with a Terrorist on top will not damage the players own units anymore.

commy2 commented 3 years ago

As well after the Demolitions upgrade: If the Demo General's Demo Bike with anything else than a Terrorist on top is destroyed it will use the Demo_SuicideDynamitePackPlusFire weapon.

If it's suicided by ability it instead uses Demo_SuicideDynamitePack, however, that button is bugged and may not be available every time depending on when you put the unit on top of the Bike and when you researched the upgrade.

Both of these also have ALLIES commented out, thus behave the same as the Terrorist after the Demolitons upgrade, but those weapons deal slightly less damage with different radii etc.

commy2 commented 3 years ago

To summarize:

Before Demolitions: Teror Bike damages allies, except other Demo General Bikes (no matter what rider). (ALLIES + NOT_SIMILAR)

After Demolitions Terror Bike does not damage allies. (ALLIES commented out)

xezon commented 3 years ago

Adding Bike Self Damage post Demo Upgrade would therefore weaken Bike effectiveness a bit. Demo player would need to be more careful when attacking with Bikes to not kill allies. Would that be desirable?

ImTimK commented 3 years ago

If the friendly blast radius isn’t too large (triggering chainreactions too easy), then this could maybe help nerfing db’s to more grounded levels, where more micro is needed (splitting, timing and sending from different angles) instead of simply waypointing unstoppable blobs with a few clicks.

Still very controversial but atleast worth testing imo.

commy2 commented 3 years ago

Would that be desirable?

It would be very confusing if they were to damage themselves only after the upgrade. If self damage is chosen, the same should happen to non-Demolitions upgrade Terrorists, which includes the other factions.

FinAminToastCrunch commented 3 years ago

Just make demobikes more expensive. Making them do more friendly fire makes them useless.

ImTimK commented 2 years ago

Revisiting this, I really like the idea of making them chain-explode easier like Nuke Battlemasters. Cause singular or a few DB's are stoppable, however gangbangs can't be stopped AT ALL and is EXACTLY what makes DB's OP.

Wouldn't even need to alter the damage, radius or cost/production values with this singular change I don't think.

commy2 commented 2 years ago

@ImTimK What change do you mean? It's not obvious to me how to proceed here.

xezon commented 2 years ago

Are you asking @ImTimK ?

ImTimK commented 2 years ago

@ImTimK What change do you mean? It's not obvious to me how to proceed here.

Currently, if you kill 1 DB in a large group, the rest survive.

So if they would chain react like Nuke BM's, then you can't sent big gangs mindlessly anymore and you would have to spread them out and coordinate more.

xezon commented 5 months ago

Regarding Demo Bikes, I would just like to note that we have merged fix

Which makes Terrorists and Demo Bikes (before Demo Upgrade) better vs USA.