search

TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
55 stars 19 forks source link

USA Drop Zone grants more money when money crate falls on different home building (?) #151

Open xezon opened 3 years ago

xezon commented 3 years ago

USA Drop Zone grants more money when money crate falls on different home building (?). Reported by Mad Rage. Investigate.

Jundiyy commented 3 years ago

Yes this is true, it's to do with the geometry of the box, could be fixed but then it also means any dropped crates from planes or when the building has been destroyed, won't be picked up easily.

ThePredatorBG commented 3 years ago

The number of times crate money is collected corresponds to the number of objects (units/buildings) the crate collides with in the same frame. So, if a crate provides $250 and collides with two structures in the same frame, the player will collect double the amount: $500.

One way to fix that, as Jundiyy mentioned, is by changing the crate geometry. A value of 0.1 will ensure the crate is collected by one object only, but the geometry of the crate becomes smaller, and the crate will be harder to collect. A better solution (untested) might be to have the crate with 0.1 geometry initially and get its vanilla geometry back after time. This might be possible by using DynamicGeometryInfoUpdate/FirestormDynamicGeometryInfoUpdate or adding a lifetime after which a different crate with proper geometry will spawn. The lifetime must be determined by measuring the time it takes from the crate spawn to the moment the crate touches the ground in-game. This way the chance of crates being picked up by multiple objects is none, or close to none, while the crates will have a normal geometry when they collide with units. By the way, the lifetime solution can be combined with a fix that prevents crates from being removed by scaffoldings. Adding the INERT KindOf will prevent buildings and scaffoldings from colliding with crates (tested). The initial crates won't have this extra KindOf, so they will collide with supply drop zones and other buildings before they land. I don't have the entire proposal tested, but I'm trying to provide some directions.

xezon commented 1 year ago

After change #1390, it appears crates no longer fall off the Drop Zone, so perhaps this is no longer a practical issue?

commy2 commented 1 year ago

Should be fixed in engine anyway.