TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
62 stars 20 forks source link

Initial upgrade/veterancy emoticon position don't work correctly #1818

Open kABUSE1 opened 1 year ago

kABUSE1 commented 1 year ago

Two examples: 1) Infantry general bunkers start with initial mines.

If you pre-place inf bunker in worldbuilder or spawn in an inf bunker via scripts, the mines are not correctly surrounding the bunker but are instead created at the coordinates 0-0, aka the bottom left corner of the map.

When an inf bunker is constructed normally, the bunker already exists when the initial mines spawn in. So the problem seems to be that the initial upgrade happens earlier than the bunker finishes the initialization routine.

2) Something similar happens when you build a unit that starts with a veterancy level upgrade. The level-up emoticon will also be visible in the bottom left corner of the map. This could potentially give players an advantage because they see whenever a unit with an initial veterancy level has been constructed, as long as the bottom left corner has no fog-of-war.

Expected behaviour in case of veterancy would be that this emoticon is not visible at all, as it would be weird to see it at the factory.

See video.

https://user-images.githubusercontent.com/47530719/230744820-6501ef17-2e37-475a-a766-103b9bf8d4ef.mp4

xezon commented 1 year ago

The veterancy animation spawning at zero is also covered by #304