TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

Cargo planes and large "jets" have different targetable logic #1858

Open kABUSE1 opened 1 year ago

kABUSE1 commented 1 year ago

All type of cargo plane can be manually targeted. They also show a mouseover unit name. Weirdly you can't laser-lock them, even though the mouse cursor suggests you can.

All bomber-type "Jets" on the other hand are fully "transparent". They show no mouse-over name and can't be manually targeted.

This should be made conistent. It's an impactful-ish change tho, as this would make stopping bombers easier, but it adds a new senseful APM, so it's cool imo.

Weird non-working laser lock: https://user-images.githubusercontent.com/47530719/232912561-b6429ca7-1c7a-4259-bbb5-7c06c77e9065.mp4

Targetability discrepancy: https://user-images.githubusercontent.com/47530719/232912508-66d5dac6-175f-480c-bf52-7be338b4df6a.mp4

Bonus suggestion, possibly controversial: Add mouse-over health bar to all large planes, similar to spectre, just keep them unselectable? Should be possible as it's already the case for USA vehicle drones.

grafik

xezon commented 1 year ago
Object AmericaJetSpectreGunship
  RadarPriority = UNIT
  KindOf = PRELOAD CAN_ATTACK VEHICLE AIRCRAFT SCORE SELECTABLE EMP_HARDENED IGNORES_SELECT_ALL
Object AmericaJetB52
  RadarPriority = UNIT
  KindOf = PRELOAD CAN_CAST_REFLECTIONS CAN_ATTACK VEHICLE SCORE TRANSPORT AIRCRAFT IGNORED_IN_GUI EMP_HARDENED
Object AmericaJetA10Thunderbolt
  RadarPriority = UNIT
  KindOf = PRELOAD CAN_CAST_REFLECTIONS CAN_ATTACK VEHICLE AIRCRAFT SCORE IGNORED_IN_GUI EMP_HARDENED
Object AmericaJetCargoPlane
  RadarPriority = UNIT
  KindOf = PRELOAD CAN_CAST_REFLECTIONS CAN_ATTACK VEHICLE SCORE TRANSPORT AIRCRAFT FORCEATTACKABLE IGNORED_IN_GUI EMP_HARDENED
Object AmericaVehicleBattleDrone
  RadarPriority = UNIT
  KindOf = PRELOAD CAN_CAST_REFLECTIONS VEHICLE SELECTABLE CAN_ATTACK DRONE NO_SELECT

I suspect the flags FORCEATTACKABLE, IGNORED_IN_GUI, SELECTABLE, NO_SELECT are of relevance here.

xezon commented 1 year ago

Removing IGNORED_IN_GUI from and adding SELECTABLE, NO_SELECT to AmericaJetB52 looks like this. The plane can be controlled.

shot_20230707_192125_2

xezon commented 1 year ago

I suspect TRANSPORT makes it show these slots.

xezon commented 1 year ago
KindOf = PRELOAD CAN_CAST_REFLECTIONS CAN_ATTACK VEHICLE SCORE AIRCRAFT EMP_HARDENED FORCEATTACKABLE NO_SELECT

shot_20230707_193157_1

Not clear to me what to do here. Perhaps add FORCEATTACKABLE to all planes.