TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

Rally point for all types of Supply Centers don't work as one would expect #1986

Open kABUSE1 opened 1 year ago

kABUSE1 commented 1 year ago

Setting a rally point for any type of supply center works counter-intuitive and isn't useful.

Right now, rally points are the same as a movement order for the collector, which is a thing that is also bugged and tracked here: https://github.com/TheSuperHackers/GeneralsGamePatch/issues/217

As with a normal movenent order, the collector continues with default behaviour after reaching destination, which is collecting goods from nearest supply source.

The counter-intuitive part is that the collector does that only once. After returning goods from nearest-supply-to-rally-point it will either go back to collecting from neareast valid source or, if there is none, it will stop moving as shown here:

https://github.com/TheSuperHackers/GeneralsGamePatch/assets/47530719/cf5adea6-8c27-426b-bca5-21297d4517bf

Best solution would be to remove the default-behaviour routine entirely, so that setting a rally point for a supply center disables auto-collecting. But then we would need the new feature to discard rally points, aka setting a building back to having no rally points. Which could possibly be a functionality that can be added to the rally point command button.

fastAiRR commented 1 year ago

wow weird, I was just about to post about this. I think we are talking about the same thing: So when I was playing in the air tourney as AFG, if I was bottom spot I would go one supply, 2 nooks at safe and a 3rd goes to the unsafe to long distance mine. Anyway, I normally put the supply center rally point to the unsafe after first two nooks are made. The 3rd chinook will fly to the rally point, collect from the unsafe, but then after that initial collection it goes to the safe to collect. Now, this isn't a major thing and is easily addressed by physically telling the nook to mine the 3rd after its built, but yea if you don't realsie its bad.

Another thing I noticed with that tourney is the top spot middle unsafe. If you place your supply a little bit too far away, the chinooks don't even go to a supply at all, not the safe or unsafe, they just sit there not mining. In some cases, they might do one collection, but then just stop. Once again, sometimes you don't notice this straight away if you are controlling raps and things, and it really fcks your eco up when you realize 5 mins later when you wonder why you have no money.

What would be cool is if you the rally button for supply centers was modified slightly so that you could do 2 things with it:

xezon commented 1 year ago

I expect this happens with all gatherers.