TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
64 stars 20 forks source link

GLA Bomb Truck can disguise into USA Spy Drone #204

Open xezon opened 3 years ago

xezon commented 3 years ago

GLA Bomb Truck can disguise into USA Spy Drone.

Jundiyy commented 3 years ago

Think it's fine.

ReLaX82 commented 2 years ago

Any ground vehicle is fine for me.

xezon commented 1 year ago

From survey comments:

bomb trucks can mimick drones from usa making it almost impossible to hit them with forced fire or seeing them coming

ImTimK commented 1 year ago

Should almost stay because it's funny, but no, I think it's broken and unrealistic.

commy2 commented 1 year ago

It can also disguise into a Battle Ship.

kABUSE1 commented 1 year ago

Best way to fix this is keep it, but make them easy to hit with force-fire by increasing click hitbox. I am not sure that is feasible as I am quite sure that this would also change the hitbox for actual drones and an increased hitbox for them might have negative consequences, as they could overlap the vehicle they are following when you are trying to hit the vehicle and not the drone.

But this should definitely be fixed, as it's a source for controversion, when used in a tournament match or something.

xezon commented 1 year ago

I think the best way to fix it is preventing disguise if target vehicle geometry is too small or too large, so that it cannot disguise as Battleship or Slave Drone.

commy2 commented 1 year ago

Nah, StealthUpdate needs to have some DisguiseForbiddenKindOf and DisguiseRequiredKindOf lists and the ability should check against those. That's how the majority of abilities control what they can and can not target.