TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
58 stars 19 forks source link

NEED_UPGRADE is messing up stolen or transfered unit weapons #2435

Open BKRFTTK opened 3 months ago

BKRFTTK commented 3 months ago

For Command Buttons, the NEED_UPGRADE option is used to prevent selecting that button until the required upgrade is researched. Due to this, another player that gains control of a unit with one of these buttons won't have access to it until that player researches the upgrade also.

Command_AmericaRangerSwitchToFlagBangGrenades

Transferred Rangers by script or ally surrender in multiplayer can't switch to Flashbangs but will keep Flashbangs if previous owner selected them and can switch to Machine Guns without restriction. Should be fine to NEED_UPGRADE option due to the default Weapon Set not having a Secondary weapon to switch to in the first place.

Command_AmericaVehicleComancheFireRocketPods

No Rocket Pods if transferred while keeping the visual upgrade. Uses Tertiary after upgrade which it lacks on the default Weapon Set. Should remove the option as well.

Command_ChinaNeutronWarhead

Same situation as Ranger but more scenarios since Nuke Cannons can be Unmanned/Hijacked too. Secondary on upgraded Weapon Set which default lacks. Should remove option for same reasons as Ranger.

Demo_Command_TertiarySuicide

All the Demo units have the Tertiary weapon in their default Weapon Sets, and several already use upgraded Weapon Sets for other purposes. I just realized these can have the option removed if the Command Button can only be accessed with a Command Set upgrade.

xezon commented 3 months ago

What happens user facing when NEED_UPGRADE is removed from these weapons?

BKRFTTK commented 3 months ago

The only difference would be that upgraded units at the time of acquisition can use those buttons while newly built units would need it. It would be no different than a Humvee or Scorpion Tank being acquired and keeping their upgrades while newly built ones wouldn't have them.