TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

China Helix and USA Comanche do emit sound in fog of war #452

Open xezon opened 3 years ago

xezon commented 3 years ago

China Helix and USA Comanche do emit sound in fog of war. Find replay attached for testing in Generals Zero Hour 1.04.

helix_sound.zip

xezon commented 3 years ago

Can be fixed in SoundEffects.ini by removing shrouded flag from relevant sounds.

AudioEvent HelixAmbientLoop
  Sounds =  vhello2a vhello2b vhello2c vhello2d
  Attack = vhello1a
  Decay = vhello3a
  Control = loop all random
  VolumeShift = -10
  Volume = 85
  Limit = 3
  MinRange = 150
  MaxRange = 1000
  Priority = normal
  Type = world shrouded everyone
End
ReLaX82 commented 2 years ago

I would say leave it as it is. Its a good part looking to Commanches.

xezon commented 2 years ago

This needs to be fixed. Note this only concerns units in fog. All infantry, planes and ground vehicles are not audible in fog. There is no rationale for Helicopters to be audible in fog. Note, that this is not related to Stealth Commanche emitting sounds in view. That can remain as is.

ImTimK commented 2 years ago

This will be a commie buff though.

xezon commented 2 years ago

If that is a concern, then there must be done something else to unbuff it.

ImTimK commented 2 years ago

If that is a concern, then there must be done something else to unbuff it.

For one thing, we could look at the experience values, Commies vet up crazy fast and then become unstoppable.

Maybe the rotor sound could also be slightly louder when in view to compensate.

commy2 commented 2 years ago

Another reason why Comanches scale so much better than other units are their armor bonuses from Countermeasures upgrade:

normal Comanche:

Armor ComancheArmor
  Armor = SMALL_ARMS        120%  ;gives Quad and gattling a little more punch.
  Armor = GATTLING          120%  ;resistant to gattling tank
Armor CountermeasuresComancheArmor
  Armor = SMALL_ARMS        75%  ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)
  Armor = GATTLING          75%  ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)

AFG Comanche:

Armor AFG_ComancheArmor
  Armor = SMALL_ARMS        100%    ;gives Quad and gattling a little more punch.
  Armor = GATTLING          100%    ;resistant to gattling tank
Armor AFG_CountermeasuresComancheArmor
  Armor = SMALL_ARMS         62%    ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)
  Armor = GATTLING           62%    ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)

Note that the EA dev comments on how much of a damage reduction the values are is completely wrong and/or at least severly misleading.

An average upgrade in the game are AP-Bullets or Uranium Shells which are +25% damage buffs.

Countermeasures however, due to the laws of mathematics, actually makes Comanches (incl. AFG Comanches) tank 60% more damage before getting destroyed than they would without upgrade.

Also, just to understand that Comanche != Comanche: Since the AFG Comanche already starts out way better, an upgraded AFG Comanche tanks 93.5% more damage than a unupgraded one from the other factions.

I am only talking about Quads, Gats and Avengers here. Missile weapons scale differently. However, these 3 units can be considered the main counters to Comanches besides idk. Stinger Sites.

ImTimK commented 2 years ago

Another reason why Comanches scale so much better than other units are their armor bonuses from Countermeasures upgrade:

normal Comanche:

Armor ComancheArmor
  Armor = SMALL_ARMS        120%  ;gives Quad and gattling a little more punch.
  Armor = GATTLING          120%  ;resistant to gattling tank
Armor CountermeasuresComancheArmor
  Armor = SMALL_ARMS        75%  ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)
  Armor = GATTLING          75%  ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)

AFG Comanche:

Armor AFG_ComancheArmor
  Armor = SMALL_ARMS        100%    ;gives Quad and gattling a little more punch.
  Armor = GATTLING          100%    ;resistant to gattling tank
Armor AFG_CountermeasuresComancheArmor
  Armor = SMALL_ARMS         62%    ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)
  Armor = GATTLING           62%    ; currently set to 37.5% increase (120 x 0.75 -- 25% reduction off ComancheArmor)

Note that the EA dev comments on how much of a damage reduction the values are is completely wrong and/or at least severly misleading.

An average upgrade in the game are AP-Bullets or Uranium Shells which are +25% damage buffs.

Countermeasures however, due to the laws of mathematics, actually makes Comanches (incl. AFG Comanches) tank 60% more damage before getting destroyed than they would without upgrade.

Also, just to understand that Comanche != Comanche: Since the AFG Comanche already starts out way better, an AFG Comanche tanks 93.5% more damage than a unupgraded one from the other factions.

I am only talking about Quads, Gats and Avengers here. Missile weapons scale differently. However, these 3 units can be considered the main counters to Comanches besides idk. Stinger Sites.

Imo normal Comanches need the exact same stats as AFG ones, with the only differences being the price and Stealth Upgrade. Which are significant differences on their own already.

Jundiyy commented 2 years ago

I wouldn't make non-Air Force Comanches any better, it's not like they are bad, just not the best, and USA doesn't need super Comanches. All that is needed for them, is a price change, so it's easier to afford them, especially Super Weapon. Secondly, Air Force being different makes sense, they are Air Force, and the Comanche looks different.

xezon commented 2 years ago

This is an Engine bug. All looped sounds can be heard in fog, if the sound gets covered in fog while the camera stays in the sound's range proximity. Sound will only turn off when out of range.

As for Helix Helicopter, the best we can do is reduce its MaxRange of 1000. It is very large.

For real fix, we need Thyme fix.