TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
64 stars 20 forks source link

EMPed Tunnels and Sneak Attacks can still evacuate Units #459

Open MTKing4 opened 3 years ago

MTKing4 commented 3 years ago

EMP Pulse (china's ultimate Promotions Power) doesn't stop tunnels and sneak attacks from evacuating units like a microwave tank does

reported by dominator

xezon commented 3 years ago

Maybe worthwhile to check if the evacuation behaves consistently accross all units and buildings under affect of EMP, and then streamline that.

MTKing4 commented 3 years ago

https://user-images.githubusercontent.com/83613147/135844312-b8ced68c-e954-4318-a213-41a2e19c5054.mp4

ECM test next, pretty sure ECM would deny all those evacs

xezon commented 3 years ago

It's very difficult to see from this test which unit evacuated and which not. Could you provide a vehicle list instead please?

You can create tables in GitHub like so

| Vehicle   | Evac on EMP |
|-----------|-------------|
| Humvee    | yes         |
| Outpost   | no          |
Vehicle Evac on EMP
Humvee yes
Outpost no
MTKing4 commented 3 years ago

all evac-ed except for the bikes, GC bus can't evac even when not disabled

MTKing4 commented 3 years ago

ECM + microwave test forgot to test bikes here, they can't evac either, even when they're back online.

https://user-images.githubusercontent.com/83613147/135849067-98c4e09c-cc76-4f77-affb-186bd17e5f7b.mp4

xezon commented 3 years ago

What about Palace, Firebase and Bunker?

MTKing4 commented 3 years ago

SW EMP works the same as China EMP, all units can evac except for bikes which can evac after being disabled, that if they survived. microwave disables evac for bunkers, firebases, palaces, internet centers get disabled + stops hackers from collecting as well

MTKing4 commented 3 years ago

bunkers, firebases, palaces, internet centers don't get Evac disabled by EMP Pulse either SW EMPs aren't even disabling friendly buildings for some reason, but they work the same as EMP Pulse so no need to test them further

https://user-images.githubusercontent.com/83613147/135855488-b29ce455-2fc4-48c8-b306-47b29562c2b1.mp4

only thing left to test is saboteur disable and hackers and Inf hackers disable which i can't test by myself without a partner

ImTimK commented 3 years ago

Always wondered about this too, I guess there's some logic behind this? Though I'm not sure if it's consistent. Like it makes sense that an EMP disables an electronic turret or vehicle door, but not preventing units from evacuating a hole/tunnel?

If we make an overview, it would be useful to also add whether it disables a weapon, like so:

Vehicle Evac on EMP Disables weapon
Humvee yes turret only ?
Outpost no no?
xezon commented 3 years ago

So is there anything that needs to be done here or can we close this?

MTKing4 commented 3 years ago

I guess giving the EMP pulse the subdued function might help buffing china factions, so it will behave the same way as ECMs

Jundiyy commented 3 years ago

So is there anything that needs to be done here or can we close this?

Looks fine.

xezon commented 3 years ago

When throwing EMP on structure, does the structure show any stun effect?

RisingZH commented 3 years ago

It would be very beneficial for gameplay if chinas emp promotion disabled sneak attack and tunnels. As it stands it is basically game over for China as soon as gla gets to lvl 5.

MTKing4 commented 3 years ago

ok so it turns out leaflet does not affect garrisons at all, same as EMP Pulse but at the same time, it doesn't disable buildings either, so evac from tunnels won't be affected while EMP Pulse does disable it and units still can evac

https://user-images.githubusercontent.com/83613147/137634746-00d270f8-fa64-4e27-903a-642c069d1900.mp4