TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

Need to retarget tunnels that are rebuilding from scaffold #483

Open Madrageeeeee opened 3 years ago

Madrageeeeee commented 3 years ago

Not too sure about when exactly this happens but i think there is a bug where you need to retarget tunnels when they are rebuilding after being hole-moded.

--> After ordering your units to attack they will kill the scaffold but then stop and will not finish the hole itself. So you need to retarget the hole, kind of annoying and weird.

Another weird thing is where the hole is actually killed but the scaffold remains? Then no new worker will spawn but the scaffold is still there. Not too sure if this is a bug or intended.

Unsure if the described bugs apply for all buildings or tunnels specifically.

Also what you can see here is that a stealth tunnel is being rebuilt: the scaffold is still visible, the new tunnel is stealthed. But you CANT actually target the visible scaffold. Which is weird. Either the entire tunnel including the hole should be stealthed or you should be able to target the visible hole.

https://youtu.be/OVxNo2izs7g?t=9841

xezon commented 3 years ago

hanfield:

There is a parameter for RebuildHoleExposeDie called TransferAttackers. It works when taking a structure from normal to hole, but i am not sure if it works for scaffold to hole. Yeah, it doesn't, transfer attackers only works for transferring aggro on the hole object, whereas the scaffold comes from the rebuild hole itself.

xezon commented 3 years ago

Likely issue here that new replacement structure spawns that invalidates attackers targets. Essentially follow up structures would have to be passed on to the current attackers of the previous structure that is replaced.