search

TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
64 stars 20 forks source link

Helixes do not get XP for kills they make using the Gattling Cannon attachment #507

Open Stubbjax opened 3 years ago

Stubbjax commented 3 years ago

Helixes do not get XP for kills they make using the Gattling Cannon attachment, whereas Overlords do. This behaviour is inconsistent and should be standardised.

https://user-images.githubusercontent.com/11547761/136394263-b087336e-9720-4e53-b4b6-3ca9459509a5.mp4

Madrageeeeee commented 3 years ago

Do units get xp for killing other units with their toxic effects? I.e. remaining nuclear radiation / toxin puddle kills etc? Does the player get xp for this?

commy2 commented 3 years ago

Do units get xp for killing other units with their toxic effects?

No.

Does the player get xp for this?

Yes.

commy2 commented 3 years ago

The problem here is, that the Overlord uses the OverlordContain module, which has a ExperienceSinkForRider token that can be set to Yes.

The Helix however uses the HelixContain module, and there is no such flag to be set.

Changing the Helix to use the OverlordContain module has its own problems however. That'd mean passengers in a Bunkerlix no longer get the +25% and +33% range bonus they usually get in a Helix. It would also mean that a Bunkerix would get the experience from the Tank Hunters, since the Helix itself has the 5 transports slots, unlike the Overlord which gets the 5 slots from the Bunker it carries only.

This is Thyme territory, sadly.