Game crashes on full screen launch if game creation resolution is not supported by the graphics adapter

[xezon]

Game crashes on full screen launch if game creation resolution is not supported by the graphics adapter.

There are 2 ways this crash can happen:

• user sets an unsupported resolution in the Options.ini himself
• user hardware does not support the minimum default resolution the game sets (800 x 600) on first launch

Steps to Reproduce:

• open %USERPROFILE%\Documents\Command and Conquer Generals Zero Hour Data\Options.ini
• set Resolution = 3840 2160 or higher, depending on monitor capabilities

Game will crash.

To fix, game should detect whether or not resolution is too low or too high and adjust Resolution accordingly. Applicable in full screen mode only. Windowed mode is not affected.

[bobtista]

Is this fixable from within this project? My gut tells me we'd need to modify the code that reads the options.ini file, something like

• read options.ini to get config x,y resolution values
• get min,max supported resolutions for game, video card, monitor
• check if the config resolution is supported
• yes: set resolution using config values
• no: set resolution to known supported values (eg min, max, or current system resolution), update config in options.ini

Is there a way to get this behavior to happen from within this repo? eg a script that just does the above check before the game launches? Is it better to fix from within Thyme or something?

[xezon]

All issues marked with "Executable" label are ultimately for Thyme to tackle.

The end goal here is that Game Patch will ship with a Super Hackers fork of Thyme.