TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

The game crashes when a certain 3D Shadow limit is exceeded #53

Open xezon opened 3 years ago

xezon commented 3 years ago

The game crashes when a certain 3D Shadow limit (4096) is exceeded.

It is W3DBufferManager that has 4096 buffer size.

Thyme has DX8VertexBufferClass and DX8IndexBufferClass reversed, which use the W3DBufferManager.

Can be tested in test map: shadow_limit_test_513_scorpions.zip

xezon commented 1 year ago

AdrianeYves:

I cannot reproduce it on contra

image

kABUSE:

Any unit that cast 3D shadows will eventually make the game crash. I don't think scorpion are especially prone to this. But as far as I remember ECM tanks are. I can build another test map if you want the exact numbers. My guess would be the more complex the 3D object, the more complex the 3D shadow, the less you need of them to exceed the vortex limit or whatever it is

AdrianeYves:

I tried a different unit from contra. The most detailed one of them all. The Saturn's shadows do not crash the game. It can achieve crash from max poly only. Screenshot_135 Screenshot_136 Screenshot_140 crash