TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
60 stars 19 forks source link

Weird behavior fuel airbomb #610

Open Madrageeeeee opened 2 years ago

Madrageeeeee commented 2 years ago

Weird dynamics fuel airbomb. Similar to the alpha aurora bomb it detonates very erratically. Sometimes it has a significant delay and weird visuals when detonating.

Think this mostly occurs when it is detonating in between buildings somehow? Unsure

commy2 commented 2 years ago

Similar to https://github.com/TheSuperHackers/GeneralsGamePatch/pull/292

commy2 commented 2 years ago

Bomb collides 50 units above terrain or building and spawns gas object. The gas object keeps falling until 40 units above terrain or building. This means that if height below the bomb or gas change during the animation, the explosion may be delayed. One way to simulate it is selling the building in time before the bomb arrives, such that the bomb collides with the scaffold, but the gas does not.

normal

https://user-images.githubusercontent.com/6576312/185660503-83746c12-2a92-446f-85df-9afaa28b19d4.mov

delayed

https://user-images.githubusercontent.com/6576312/185660561-704a80d3-6196-49cf-9c50-0a9262140aa2.mov

xezon commented 2 years ago

Does this behavior impose any practical issues?

commy2 commented 2 years ago

Bomb may go off late. I have seen longer delays, but haven't found a way to reproduce them.

xezon commented 2 years ago

Is there any parameter in bomb that looks as if it could influence this?

commy2 commented 2 years ago

The entire HeightDieUpdate module of the DaisyCutterGas object:

    TargetHeight                     = 40.0
    TargetHeightIncludesStructures   = Yes
    DestroyAttachedParticlesAtHeight = 41.0   ; Hack, todo remove this

Note that the object has 1 hitpoint and normal ProjectileArmor, so it can be hit and destroyed by crossfire splash damage.

xezon commented 2 years ago

; Hack, todo remove this xD