TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
53 stars 19 forks source link

Non-controllable planes will fly in circles over certain objects #676

Open xezon opened 2 years ago

xezon commented 2 years ago

Non-controllable planes will fly in circles over certain objects.

See Replay at 09:43 minutes.

carpet_bomber_circles.zip

Goldfish:

The reason the plane bugged is because of the planes on the ground. I made a test map with a wall of these and the a10's got stuck above them flying circles for minutes.

post-884445-1651762453

More structures have been identified to trigger this supposed "collision avoidance" behaviour:

post-884445-1651769921

post-884445-1651769931

post-884445-1651769940

post-884445-1651769949

ECBVovin commented 1 year ago

These have KindOf AIRCRAFT_PATH_AROUND. Which make aircraft path around. Can cause weird issues with things going in circles. Wouldn't suggest using on maps.

xezon commented 1 year ago

AsianMegaHotel01: AIRCRAFT_PATH_AROUND

Damn.

Maybe it would be no harm to remove all these flags and just let planes clip through these mega hotels and smaller things.

Jundiyy commented 1 year ago

Perhaps maybe a carbon copy and have the code in the copy? So they can still be used in fun maps? This would mean all pvp maps would be auto fixes, but also non pvp maps (in case someone wanted it in). I don't think anyone would miss them but at least they can still use them if they wish.

Could also try editing locomotor, maybe it could fix the circling, don't know how much is needed.

ImTimK commented 1 year ago

Make aircraft and buildings go boom?

9/11? :O

commy2 commented 1 year ago

map.ini can add

Object AsianMegaHotel01
    KindOf = -AIRCRAFT_PATH_AROUND
End
xezon commented 1 year ago

Or

Object AsianMegaHotel01
    KindOf = +AIRCRAFT_PATH_AROUND
End

to avoid carbon copies. But will this introduce INI mismatch? xD

Jundiyy commented 1 year ago

Probably since it forces planes to move differently.

xezon commented 1 year ago

There are 41 hits for AIRCRAFT_PATH_AROUND. I would prefer to not make copies. Makes the setup unnecessarily more complicated. Keep it simple for whatever works best. I would like to remove the flags and test.