TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
63 stars 20 forks source link

China Hacker(s) stop hacking inside Internet Center when pressing STOP key #767

Open xezon opened 2 years ago

xezon commented 2 years ago

China Hacker(s) stop hacking inside Internet Center when pressing STOP key. Hacker(s) will have to be evacuated and reentered to start hacking again.

xezon commented 2 years ago

Enlima29:

I once meddled with hacker van, where those are mobile internet center where hackers can enter them to generate money. I accidentally pressed stop command on it and the hackers inside stopped hacking. But then if I disable it by EMP or subdual, when the van is back online and the hackers inside starts hacking again for some reason. So I guess make a special button for the internet center that will disable (stun) it for like 0.1 second and have the button have S as hotkey so it will be triggered along with the stop command?

Jundiyy:

Having conflicting hotkeys doesn't set both of them off as far as I know? 1 overrides the other. Also, if you disable it for 0.1s, wil this not impact it when disabled in other ways? It will instantly turn back on all the time.

xezon:

If a key mapping S would prevent S hotkey to take effect as Jundiyy suggests, then that would also inherently prevent the issue.

DoMiNaToRuk2 commented 2 years ago

Please stop that stop

xezon commented 1 year ago

Unfortunately, the Sat Hack upgrade button is bound to S. So pressing S to get or use upgrade will also stop the Hackers.

shot_20230215_185826_1

xezon commented 1 year ago

Removing S shortcut from button does not prevent bug.

xezon commented 1 year ago
  Behavior InternetHackContain
    ContainMax
    EnterSound
    ExitSound
    DamagePercentToUnits
    BurnedDeathToUnits
    AllowInsideKindOf
    ForbidInsideKindOf
    PassengersAllowedToFire
    PassengersInTurret
    NumberOfExitPaths
    DoorOpenTime
    WeaponBonusPassedToPassengers
    AllowAlliesInside
    AllowEnemiesInside
    AllowNeutralInside
    DeathTypes
    VeterancyLevels
    ExemptStatus
    RequiredStatus
    Slots
    ScatterNearbyOnExit
    OrientLikeContainerOnExit
    KeepContainerVelocityOnExit
    GoAggressiveOnExit
    ResetMoodCheckTimeOnExit
    DestroyRidersWhoAreNotFreeToExit
    ExitBone
    ExitPitchRate
    InitialPayload
    HealthRegen%PerSec
    ExitDelay
    ArmedRidersUpgradeMyWeaponSet
    DelayExitInAir
xezon commented 1 year ago

Using ContainMax instead of Slots does not work.

xezon commented 1 year ago

Adding PassengersInTurret = Yes does not fix it.

xezon commented 1 year ago

Looks like code issue. The behaviour is identical on other structures. For example loading rocket men into Bunker, shooting and then pressing stop on Bunker will make the rocket men stop firing. So we probably would need to add a new feature like ForwardUnitCommandsToPassengers = No with the default being Yes.

commy2 commented 1 year ago

Or a flag that disabled Stop entirely. It can then be given to Scud Storm as well.

You still need to pass the evacuate command.

xezon commented 1 year ago

Evacuate command is structure button.

MTKing4 commented 1 year ago

Then put the sathack on a different hotkey? Maybe K Worst case scenario for sathack is to add stop button

And maybe start hacking button as well if that's possible

xezon commented 1 year ago

Yes as long as we cannot fix this issue, remapping hack to different hotkey is desired. We could map it to H for "Hack".

commy2 commented 1 year ago

H is "Home", brings you to your oldest CC. Ctrl+H is hero, brings you to your oldest hero.

xezon commented 1 year ago

F

MTKing4 commented 1 year ago

Yeah i thought about H but as commy Said it's not available, closest we have is K or T

I wouldn't put any of the following A L I C E as they're too common in most words and I can be confused with L

commy2 commented 1 year ago

Why not A? It has no attack move. A is a good key for buildings, and it's easy to reach (unlike, e.g. L)

MTKing4 commented 1 year ago

I don't like it, it's common vowel, and also known for attack move

MTKing4 commented 1 year ago

If you like close letters then T is pretty close

xezon commented 1 year ago

A looks good to me. Close to former S.

ImTimK commented 1 year ago

A is good, the original hotkeys use the same logic, if the first letter of the Unit/Structure/Upgrade name isn't available, the next letter is used.

A is also nicely reachable.

MTKing4 commented 1 year ago

I'm going to stop my hackers a lot every time i issue an attack move while having my IC selected

if the first letter of the ~Unit/Structure/Upgrade~ Command name isn't available, the next letter is used.

sTop

xezon commented 1 year ago

Perhaps a silly thought but I wonder could the ability to stop the hackers perhaps be useful in some cases? Since the enemy can see the green numbers of the active Hackers above the Internet Center, one could try to momentarily conceal their presence and make it look as if the Internet Center is empty, for example when the enemy USA player activates their Strategy Center Battle Plan and uses the Satellite Intelligence ability to see the whole map.

ImTimK commented 1 year ago

I'm going to stop my hackers a lot every time i issue an attack move while having my IC selected

if the first letter of the ~Unit/Structure/Upgrade~ Command name isn't available, the next letter is used.

sTop

How so, why would you press S when it's on A?

sAtellite hack

You don't use any A's, S's, G's, X's, V's (attack move, stop, guard mode, scatter, evac) or whatever commands in your production facilities? Tbh it sounds like your hotkey options are very limited and decentralized if you get confused that easy, I never accidentally tried to attack move my structures 🤣, seems to be a personal problem.

Perhaps a silly thought but I wonder could the ability to stop the hackers perhaps be useful in some cases? Since the enemy can see the green numbers of the active Hackers above the Internet Center, one could try to momentarily conceal their presence and make it look as if the Internet Center is empty, for example when the enemy USA player activates their Strategy Center Battle Plan and uses the Satellite Intelligence ability to see the whole map.

Doesn't sound useful at all tbf 😄