search

TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
55 stars 19 forks source link

China Dragon Tank's Flame Wall does not grant veterancy #917

Open xezon opened 2 years ago

xezon commented 2 years ago

China Dragon Tank's Flame Wall does not grant veterancy to the owning tank. Likewise, Flame Wall damage will not scale with veterancy level of owning tank.

Related

Zeke:

Legend says that you can fix this by giving the projectiles slaved update. Legend also says it can be fixed by converting some of the death/detonation OCLs to fireweapon, since apparently units do get exp from kills by weapons fired by their projectiles. The SWG Aurora in ShockWave gets EXP correctly and it uses the fireweapon OCL.

ReLaX82 commented 2 years ago

If I destroy a building with the firewall dont the flamer gets vetted already? Maybe I dont understand.

commy2 commented 2 years ago

The firewall does not pass XP to the Dragon tank. The pro meta is giving the kill shot to the normal flame weapon instead of the fire wall to vet up the Dragon.

ReLaX82 commented 2 years ago

If its giving all XP to the normal flame weapon and takes XP from all kills inside the flamewall its fine, but I think the flamewall doesnt change with XP right?

Jundiyy commented 2 years ago

This is not entirely true, there is a part of the Firewall which does grant xp and a part which doesn't. The part which is connected during the Firewall will grant xp to the unit (you can see the difference, it looks like a straight line which moves with the turret). If the flame has started to travel and the flame kills/destroys the unit, then it won't grant the Dragon Tank xp. You can understand it in the same way that a Mig or Inferno will shoot at something, if they kill with the actual shell, they gain vet, otherwise with the firestorm they won't. The same here, the first part of the weapon is the shell and the flame is the firewall. Same example for other units.

1) Firewall is being used, the Dragon Tank's turret is towards the Tunnel Network when it is destroyed (at a close range, this distance is a bit less than how far the line actually goes, a good estimate is to use the normal weapon and see where the Dragon Tank stops, then you have to come at least 1 Dragon Tank space closer) it will get xp. 2) Firewall is being used, the Dragon Tank's turret is not towards the Tunnel Network when it is destroyed (distance or no distance), it won't get xp. 3) Firewall is being used from a distance, (further out than mentioned above) the turret is facing the Tunnel Network when destroyed, unit will not gain xp.

Note: You will notice that the Dragon Tanks which use a Firewall right next to a building, especially a larger one, will usually vet up, this is because their turret is most likely facing the building as it is closer, so less room to miss the building, and that first flame will usually destroy the building.

ZekeDlyoung commented 2 years ago

If its giving all XP to the normal flame weapon and takes XP from all kills inside the flamewall its fine, but I think the flamewall doesnt change with XP right?

Atm no, but this can be changed by setting specific veterancy weapons to units

xezon commented 1 year ago

The sane approach forward is to fix this issue, where China Flame Wall grants unit XP as one would naturally expect. If Dragon Tank levels up too quickly as a result of that, then XP requirements can be tweaked accordingly.