search

TheSven73 / file-objects-rs

Real and fake implementations of file system operations
MIT License
2 stars 1 forks source link

Canonicalize temp dirs created for tests #10

Closed TheSven73 closed 4 years ago

TheSven73 commented 4 years ago

If I understand correctly, #6 #7 #8 are all related to the fact that some OSes (macos in particular) may create temp dirs that are not canonical?

@2-complex are you able to see if this commit solves these issues in particular? If so, we can kill save three birds with one stone ?

TheSven73 commented 4 years ago

I tested this commit on macos using Travis CI, and it fixes all tests, except two: https://travis-ci.com/github/TheSven73/file-objects-rs/jobs/356109550

Are you ok to replace #6 #7 #8 with this commit?

2-complex commented 4 years ago

Are you ok to replace #6 #7 #8 with this commit?

Go for it 👍

2-complex commented 4 years ago

I tried it on my computer and only two tests fail: os::remove_file_fails_if_node_is_a_directory and os::canonicalize_fails_if_subpath_is_file