TheSwain / Fulpstation

Fulpstation's downstream of TG
https://fulpstation.com
GNU Affero General Public License v3.0
21 stars 41 forks source link

Adds new function on the Communications Console, allows any Mod+ to call ERT if requested #481

Closed SgtHunk closed 4 years ago

SgtHunk commented 4 years ago

About The Pull Request

NOTE: This was more of me messing around. It's not expected to be merged.

This adds the new Admin command "ERT" which instantly redirects to the Create Antagonist -> Emergency Response Team section. This new command appears after the new Communications console function (which requires Captain level access) is used, called "Request CentCom Personnel". This allows Admins to send in ERTs and its subtypes. INCLUDING CentCom Officials.

image

Why It's Good For The Game

image

Makes sending ERTs slightly easier, and makes requesting them a separate thing than simply contacting CentCom.

Changelog

:cl: add: Added "Request CentCom Personnel" function for Communications console. add: Added "ERT" Admin command to go with the mentioned above function, in case the higher ups wish to send any ERT and its subtypes (ERP, CentCom Official, Interns, etc) /:cl:

BlueMemesauce commented 4 years ago

I dont really understand, why not just click "Send message to centcom" and type in we need ert

BlueMemesauce commented 4 years ago

you should add the ERT button to the "Send message to centcom" too

SgtHunk commented 4 years ago

Simply because the CentCom message is for more in-general usage Also, if I added this to the CentCom message function instead then mods could call ERT on any centcom message Which feels... rather like a flaw. With this button, atleast now someone will have to specifically request for a Mod to call any subtype of ERT. Instead of y'know, waiting for an Admin Candidate+ or being able to call one because someone requested something simple using the normal message function.

BlueMemesauce commented 4 years ago

i dont really understand fulp why cant mods call the ert why is that an admin only thing or whatever

BlueMemesauce commented 4 years ago

so mods can only spawn in an ERT when the captain clicks the request centcom personnel button thats dumb

SgtHunk commented 4 years ago

It's because it's a subtype of the "Create Antagonist" button Letting mods create ERT through admin perms would also let them access the entirety of "Game - Events" If this does go through, then at least mods will be able to do things like spawn a CentCom Official or whatever subtype of ERT they wish

manray0 commented 4 years ago

Not sure how this will work, considering mods don't have access to +SPAWN, would be keen for a testmerge

SgtHunk commented 4 years ago

this uses the same check for nuke code requests (which mods can INDEED use and give)

github-actions[bot] commented 4 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself