TheSwain / Fulpstation

Fulpstation's downstream of TG
https://fulpstation.com
GNU Affero General Public License v3.0
21 stars 41 forks source link

scooby doo type traitor kit atmos traitor exclusive #511

Closed Unstagrav closed 4 years ago

Unstagrav commented 4 years ago

Unstagravs holodragon PR, also my first PR, so please don't bully me too bad. this is my Halloween submission. lol all criticism is appreciated.

ADDS: 20 TC, atmospheric technician traitor exclusive kit. Fire/burn proof suit that makes you LOOK like a dragon with no movement debuff. THIS IS NOT SPACE WORTHY. Comes with a flamethrower free of charge. Very mild melee/laser protection on the suit. You must wear the shoes, atmos. All the code for all this shit in the fulp/halloweencostumes place.

ADDS: makes ian say silly things if you put this hat on his head. lol

CHANGE: updates atmospheric technician jumpsuit to not take fire damage. YOU STILL BURN TO DEATH. and despite it saying null on resistance flags you can still blow the atmospherics jumpsuit off with bombs. This is so I don't have to make the costume a hardsuit, yet protects whatevers in your scurvy pockets, you fire breathing maniac. I slapped this shit in the fulp overwrite place.

BUG-FIX: updated atmos jumpskirt to have same resistances and flags as jumpsuit (idk why it wasn't like that)

Why in the fuck?: atmos techs need love too baby. if they want to burn stuff they were going to anyways. I added some flavor on the paper included basically telling people not to be ding dongs with the kit. I just had fun making all this so I don't really care if it gets merged or not. lol (:

Is there a feet reference in there?: perhaps _

image

image

thatlooksddumb_oh

AFFECTED FILES: fulp_overwrite_vars.dm, holodragon.dm, costumes_worn.dmi, costumes_icon.dmi, tgstation.dme thanks for reading

GuillaumePrata commented 4 years ago

Overwriting objects doesn't work like that and changing the jumpsuits in TG code isn't that wise either. It's should be easier to make this a firesuit equivalent and remove the slowdown, it doesn't need to be a hardsuit.

ATH1909 commented 4 years ago

It'd be nice if this came with an item that'd let you fake a space dragon arrival announcement.

Also, don't be surprised if someone ditches the flamethrower from this kit entirely and instead uses it as a way to cover up the fact that they're holding a shotgun, flash, etc. I mean, it's a 20 TC item, so it should be fine, but still.

Oh, speaking of which, does this conceal your identity at all? If not, maybe add a chameleon gas mask to it and an ID card (or even an agent card) that's named "space dragon" or something.

Unstagrav commented 4 years ago

Overwriting objects doesn't work like that and changing the jumpsuits in TG code isn't that wise either. It's should be easier to make this a firesuit equivalent and remove the slowdown, it doesn't need to be a hardsuit.

hey thanks for the look. can you tell me what you mean by the over writes being bad?

i put my jumpsuit over write into

/code/zFulpstationCode/fulp_overwrite_vars.dm

and whats nice is that it worked as intended. image it seems that place is literally meant for over writes infact. so I don't understand what you're saying because I didn't alter the TG code from its place of origin. would you eleborate?

Unstagrav commented 4 years ago

It'd be nice if this came with an item that'd let you fake a space dragon arrival announcement. Also, don't be surprised if someone ditches the flamethrower from this kit entirely and instead uses it as a way to cover up the fact that they're holding a shotgun, flash, etc. I mean, it's a 20 TC item, so it should be fine, but still. Oh, speaking of which, does this conceal your identity at all? If not, maybe add a chameleon gas mask to it and an ID card (or even an agent card) that's named "space dragon" or something.

lol the fake announcement sounds really funny.

no it doesnt conceal your identity, i guess a lad would have to slap that PDA into their backpack and be "Unknown". a new examine would be cool if you're wearing both i think. i could try and look into it, no promises tho as idk if this would even get merged as is lol

github-actions[bot] commented 4 years ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

BlueMemesauce commented 4 years ago

it is pretty expensive just for a decorative costume it should be way cheaper

ATH1909 commented 4 years ago

it is pretty expensive just for a decorative costume it should be way cheaper

it hides your in-hands