search

TheTeaCat / lastfm-tag-cloud

A last.fm tag cloud generator, built with Vue!
https://tagcloud.joshuarainbow.co.uk/
MIT License
31 stars 3 forks source link

Custom colours reset on reshuffle #42

Closed TheTeaCat closed 4 years ago

TheTeaCat commented 4 years ago

...probably another big caused by the latest refactor, likely an easy stupid fix.

Steps to reproduce

On mobile, chrome:

  1. Change one of the colours
  2. Tap "reshuffle"

Expected behaviour

Should generate a tag cloud with the colour set.

Actual behaviour

Resets the colours back to their theme defaults (light/dark theme) and generates a cloud with those colours.

TheTeaCat commented 4 years ago

Also occurs when changing between artist/tag clouds and check/unchecking tags in the tags list.

TheTeaCat commented 4 years ago

8f04490a9d89b9be0dac6a1c6e310103230c7680 didn't actually fix this, it is now impossible to set the colours to the opposite theme colours. E.g. text to #ffffff and the background to #000000 while in light mode.

TheTeaCat commented 4 years ago

2f282f5b9d2f73a3f9794477597a627c8762438c introduces a fix that maintains the features of both custom colours and the colours changing to match the page theme that's nice and simple.