search

TheTechnobear / Mi4Pd

Pure Data externals wrapping MI modules
92 stars 13 forks source link

get rid of checked in m_pd.h #13

Closed umlaeute closed 3 years ago

umlaeute commented 3 years ago

m_pd.h really shouldn't be present in the repository, as it is tightly coupled Pd itself. including it here, forces to support only a specific version of Pd.

Pd is (mostly?) API & ABI compatible for the last 20 years or so, but the file does change and introduces new features, some of them automatically.

related: you might consider using pd.build as the basis for your CMake project, as (I think) it wraps much of the ugliness when using CMake with Pd.

TheTechnobear commented 3 years ago

PD are very unlikely to break the ABI compatiblity at this stage, so it feels better to keep m_pd.h so its easier for users to compile without having to start setting a PD path. esp. as on some OS where PD is installed is variable esp. (e.g. on macOs we tend to have it in /Applications under the app BUT the app has version number so you cannot really just 'guess' which one to use)

umlaeute commented 3 years ago

you are definitely missing out on any double-precision changes, but that is of course your call to make.