search

TheTemportalist / Compression

2 stars 0 forks source link

Crash when clicking on an item in JEI #11

Closed MoxieGrrl closed 8 years ago

MoxieGrrl commented 8 years ago

When opening the inventory and trying to click on a Neotech battery to get the recipe, the game crashes to desktop. Crash report.

TheTemportalist commented 8 years ago

Has this been reported to Neotech? it looks like its their baked class which is doing the erroring (despite being caused by Compression). java.lang.NullPointerException: Rendering item at com.teambr.bookshelf.client.models.BakedDynItem.func_188616_a(BakedDynItem.java:78)

TheTemportalist commented 8 years ago

specifically this line: https://github.com/TeamBR-Modding/Bookshelf/blob/1.9/src/main/scala/com/teambr/bookshelf/client/models/BakedDynItem.java#L78

Insufficient-Charge commented 8 years ago

I have something to add to this. This is also happening with the E-flux mod. I reported this to the author of JEI and he said to report it here. Seeing a similar issue, I guess I'll report it here. Some of the items are crashing when you look up a recipe from any mod in the game it appears. More commonly with Neotech and E-flux, but, whatever it is that's causing this, is happening within Compression. https://github.com/mezz/JustEnoughItems/issues/276#issuecomment-219570728

TheTemportalist commented 8 years ago

Ultimately this is a team Bookshelf issue. Their BakedDynItem assumes its textures are non-null. The next release, however, will include the ability to blackllist items. That way they dont cause crashes.

TheTemportalist commented 8 years ago

See https://github.com/TheTemportalist/Compression/commit/37ff879b2a3f208efff36c2c10a137ba6199bc11

TheTemportalist commented 8 years ago

When it gets approved, this is the version you will want http://minecraft.curseforge.com/projects/compression/files/2302966