TheTemportalist
commented
9 years ago Thank you for the content. However, this should be broken up into multiple issues, because there is discussion to be held for separate parts.
Closed skyjay1 closed 9 years ago
TheTemportalist
commented
9 years ago Thank you for the content. However, this should be broken up into multiple issues, because there is discussion to be held for separate parts.
TheTemportalist
commented
9 years ago This issue will be closed and discussion can occur in the subsequent issues.
These are observed from the latest 1.7.10 build (4.0.0)
1) Angels sometimes turn while player is looking. 2) Angels do not know player is looking if the player can only see their bottom half (eg, when top half is obscured by a block). Possible solution: use look vectors from the player's head to both the angel's head and the angel's feet. 3) Angels "bounce" in water as they try to swim, even when player is looking. Solution: remove the EntityAISwimming. After testing, I determined that entities can go walk up and down in water if their step height is at least 1.0F -- besides, stone doesn't float. 4) Angels seem to pick up items and place them on their head? I have not tried to replicate this, but sometimes a fallen block item ends up on top of the angel if it walks into the item. 5) Incompatibility: Twilight Forest dimension land-level and sea-level is much lower than other dimensions, so angels spawn uncontrollably unless I am willing to set their max spawn height to 5. Possible solution: add a dimension ID "blacklist" to the config. If desired, ignore if the user tries to blacklist the overworld (if they add "1" to the blacklist). Aside from this, the config is very flexible and well-implemented. 6) Statue GUI shows the statue facing the player until rotation is manually set. It then shows the statue oriented away from the player, making it difficult to preview other options like arm and wing states. 7) Statue GUI has typo -- the button labeled "Peaking" should be labeled "Peeking" 8) Missing texture for statue item (when held or in inventory) -- disabling Optifine did not fix the problem. 9) After adjusting the decripitation of one angel statue's texture, the next time I loaded the world all the statue textures were completely white until I reset the original statue's decripitation. This was in a server setting. 10) Why are the block bounds for the statue so low? Is it simply to make it harder to distinguish a statue from an EntityAngel? If so, it doesn't fool Waila. 11) this.getNavigator().setEnterDoors(true); is not in the EntityAngel (this enables walking through OPEN doors only). I have not been dumb / brave enough to leave a door open, so I do not know if they can enter doors without it.
That's all I could think of for now. Hopefully you have a chance to adjust these features in the next 1.8 release. Overall, outstanding work and a very creative mod!