search

TheThingsArchive / api

Generated code for accessing The Things Network v2 API
MIT License
12 stars 8 forks source link

[go] Non-nullable fields #12

Closed rvolosatovs closed 7 years ago

rvolosatovs commented 7 years ago

Not quite sure if in handlerclient app is guaranteed to be non-nil. @htdvisser, is it? (I mean https://github.com/TheThingsNetwork/api/compare/feature/go-nullable?expand=1#diff-586f5b5b2a5a483a673498fcaf77d9ceR160). PR to ttn will be opened as soon as this is merged.

htdvisser commented 7 years ago

Not quite sure if in handlerclient app is guaranteed to be non-nil.

handlerclient DryUplink and DryDownlink indeed have a non-nullable App field.

rvolosatovs commented 7 years ago

so the *app statements are fine?

rvolosatovs commented 7 years ago

@htdvisser

htdvisser commented 7 years ago

Yes, if no app is supplied, it should panic

rvolosatovs commented 7 years ago

@htdvisser

htdvisser commented 7 years ago

Github says no:

screen shot 2017-08-02 at 10 38 33
rvolosatovs commented 7 years ago

they were not there 7 days ago, when you approved the PR. I will make it work now

rvolosatovs commented 7 years ago

@htdvisser

htdvisser commented 7 years ago

Travis CI is failing because .travis.yml is not in this branch yet. Merge is therefore OK