Closed rvolosatovs closed 7 years ago
Not quite sure if in handlerclient app is guaranteed to be non-nil.
handlerclient
DryUplink
and DryDownlink
indeed have a non-nullable App
field.
so the *app
statements are fine?
@htdvisser
Yes, if no app is supplied, it should panic
@htdvisser
Github says no:
they were not there 7 days ago, when you approved the PR. I will make it work now
@htdvisser
Travis CI is failing because .travis.yml
is not in this branch yet. Merge is therefore OK
Not quite sure if in
handlerclient
app
is guaranteed to be non-nil. @htdvisser, is it? (I mean https://github.com/TheThingsNetwork/api/compare/feature/go-nullable?expand=1#diff-586f5b5b2a5a483a673498fcaf77d9ceR160). PR to ttn will be opened as soon as this is merged.