search

TheThingsArchive / api

Generated code for accessing The Things Network v2 API
MIT License
12 stars 8 forks source link

Compile protos in-Docker, setup CI, generify build, generate protos,mocks on CI #16

Closed rvolosatovs closed 7 years ago

rvolosatovs commented 7 years ago

Created a https://github.com/TheThingsIndustries/docker-protobuf protoc Docker image, which contains

protoc-c command is wrapped and executed automatically if --c_out= is specified, if some other output directive is specified(e.g. --ruby_out), the wrapper will invoke both protoc-c and protoc with appropriate directives.

Currently it's possible to compile for following languages:

I'll implement missing language support in the next step (#15)

I added a protos build target to be consistent with naming of other build targets, I changed the way we determine GOPATH, with this implementation, as long as the package is located at <somepath>/src/github.com/TheThingsNetwork/api and the user has docker and git installed, it will be possible to compile out protos, no go or specific environment variables needed

Not sure how we can make compiled protos from CI end up in the repo. Giving write access to the CI is probably not the best idea. We could make releases. I added a very simple travis.yml, it regenerates all compiled code and fails if diff with HEAD is non-empty. Therefore protos/mocks should be compiled on dev machine, while CI would check the output.

You will notice some file removals: There were some java files included in the repo, which seem to be located in the wrong place(whey also exist in the expected locations). For example,java/src/lorawan/DevAddrManagerGrpc.java was duplicated at org/thethingsnetwork/api/protocol/lorawan/DevAddrManagerGrpc.java

Changes in the protos/mocks is due to the change in versions - the image uses the latest tagged versions of packages(excluding go, which are go get'ed from master) Closes #1

rvolosatovs commented 7 years ago

@htdvisser