Closed singularsyntax closed 3 years ago
For JS and Python we just run sed
to delete all lines containing references to the (unused) gogo
and annotations
. That may also be a solution here, in which case we shoul probably remove all references to com.google.api.AnnotationsProto
or com.google.protobuf.GoGoProtos
from the generated Java code.
Removing references to those two classes throughout the generated Java source files tree does indeed fix the compilation failure.
Hi @singularsyntax, I added a post-process rule to the Makefile that deletes references to GoGo and AnnotationsProto from the Java files. I pushed the commit to https://github.com/TheThingsNetwork/api/tree/feature/gogo-java, could you check that branch to see if it works for you?
I'm going to close this issue. We're not going to address it anymore, as V2 is going to shut down in December.
The API build process uses gogoprotobuf which extends standard protobufs. Thus, the generated Java source files contain references to GoGoProtos classes and fails to build:
Presumably, the protobufs import resolution process retrieves and generates these source files as well, but they are not checked in. Would it be straightforward to check these into the Git repository as well, so that the Java classes can be compiled?
Unfortunately, build issues (#29) prevent me from attempting to generate the GoGoProtos classes in my own environment.