search

TheThingsArchive / api

Generated code for accessing The Things Network v2 API
MIT License
12 stars 8 forks source link

Feature/csharp #40

Closed LukasHabring closed 3 years ago

LukasHabring commented 4 years ago

Added csharp as target language. Unfortunately I had to remove gogoproto in order to do that. Results should be binary compatible though.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

jpmeijers commented 4 years ago

I believe you are experiencing the same issue as java, documented in https://github.com/TheThingsNetwork/api/issues/30. Can you try that workaround?

After speaking to the gogoproto maintainer it sounds like an issue of proto3 dropping features that proto2 had, that gogoproto depends on. And that the java and dotnet proto compilers don't support proto2 properly.

https://stackoverflow.com/questions/41833044/c-sharp-code-generation-with-google-protobuf-proto2-files

https://github.com/protocolbuffers/protobuf/issues/6067

LukasHabring commented 4 years ago

@jpmeijers Thank you for your reply. It should be fixed now.

htdvisser commented 3 years ago

I'm going to close this stale pull request. We don't intend to make any changes to this repository since V2 is permanently shutting down in December.