TheThingsArchive / java-app-sdk

The Things Network Application SDK for Java
MIT License
30 stars 25 forks source link

MOD: OSGi manifest headers #20

Closed IOOOTARobby closed 7 years ago

IOOOTARobby commented 7 years ago

Introduced bundle packaging through maven-bundle-plugin.

java-app-lib solely depends on org.eclipse.paho/org.eclipse.paho.client.mqttv3 and org.json/json: both this artifacts are built as Java OSGi bundles.

I have added the maven-bundle-plugin to the POM and changed the packaging mode to "bundle": this way the generated JAR has all the needed manifest headers to be a proper OSGi bundle itself.

The usage of the JAR as a simple standalone Java library is totally unchanged, but now the same library can properly execute inside an OSGi runtime, like Apache Felix, Eclipse Equinox and so on.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

FokkeZB commented 7 years ago

Thanks @IOOOTA!

cambierr commented 7 years ago

Fine. Thanks for your contribution @IOOOTA !

I can't merge if myself, @johanstokking

johanstokking commented 7 years ago

@cambierr now you can!

cambierr commented 7 years ago

Great, thanks !

IOOOTARobby commented 7 years ago

It's a pleasure @cambierr, thanks to TTN for the opportunity :+1: