Closed FokkeZB closed 8 years ago
Some additional thoughts:
reply(msg, buffer)
) so that the send/downlink()
method stays simple.Closing. This would make it look too much like a response, which it is not.
We can do a response in fact. I guess there are many use cases in which you want to respond within the receive window.
For it to be a response is merely a matter of timing right? Implementing this API wouldn't guarantee it to be delivered as response
True. But it would be nice to make it easily accessible in the SDKs.
Also, we're extending RX1 from 1 second to 5 seconds to be able to make the roundtrip possible.
OK, but then I'd suggest to support client.send(msg, payload)
to make it less prone to be confused for a guaranteed response then msg.respond(payload)
.
Closing as dev_id
is no longer in payload.
See: https://github.com/TheThingsNetwork/node-app-lib/pull/25#discussion_r80195257
This way the user could do:
If
downlink()
sees the first argument is an object it would then usemsg.dev_eui
(andmsg.port
?) to do the downlink.See https://github.com/TheThingsNetwork/node-app-lib/issues/2#issuecomment-247863572 for reasoning against:
An alternative implementation is for
msg
to have a downlink method that binds to the client with thedev_eui
(andport
?) already set: