Closed romeovs closed 7 years ago
Currently, there's something wrong with the gRPC client and it won't connect to discovery.thethings.network:1900
for instance, failing with a:
9356:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown
I think this is caused by the server only supporting TLSv1.x
and the gRPC client wanting to connect using SSLv3
but I can't reproduce it locally. Maybe @htdvisser can have a look?
Let's not merge it until that issue gets fixed.
I don't know if we should support SSLv3 though. This issue doesn't happen with other endpoints (e.g. Handler)?
@romeovs
Please reopen when tests pass and conflicts are resolved
The tests are fixed!
@romeovs still blocked?
@johanstokking it should be okay. It's just waiting for a review :)
This PR:
documentation.js
to document the codebasego-app-sdk
api betterThis has some breaking API changes but migrating should be easy.