TheThingsArchive / node-app-sdk

The Things Network Application SDK for Node.JS
https://www.thethingsnetwork.org/docs/node-js/
MIT License
41 stars 28 forks source link

Use secure gRPC api's instead of HTTP api's, use discovery, clean up codebase #64

Closed romeovs closed 7 years ago

romeovs commented 7 years ago

This PR:

This has some breaking API changes but migrating should be easy.

romeovs commented 7 years ago

Currently, there's something wrong with the gRPC client and it won't connect to discovery.thethings.network:1900 for instance, failing with a:

9356:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown

I think this is caused by the server only supporting TLSv1.x and the gRPC client wanting to connect using SSLv3 but I can't reproduce it locally. Maybe @htdvisser can have a look?

johanstokking commented 7 years ago

Let's not merge it until that issue gets fixed.

I don't know if we should support SSLv3 though. This issue doesn't happen with other endpoints (e.g. Handler)?

johanstokking commented 7 years ago

@romeovs

htdvisser commented 7 years ago
johanstokking commented 7 years ago

Please reopen when tests pass and conflicts are resolved

romeovs commented 7 years ago

The tests are fixed!

johanstokking commented 7 years ago

@romeovs still blocked?

romeovs commented 7 years ago

@johanstokking it should be okay. It's just waiting for a review :)