search

TheThingsArchive / packet_forwarder

Packet forwarder for Linux based gateways
MIT License
84 stars 92 forks source link

antenna_gain prop for poly_pkt_fwd #90

Closed hb9fxq closed 6 years ago

hb9fxq commented 6 years ago

New property/function "antenna_gain" ....eg: 10, / antenna gain, in dBi / for gateway_config to reduce RF power to legal boundaries when using higher gain antennas.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

hb9fxq commented 6 years ago

no Idea, why travis fails....

johanstokking commented 6 years ago

@krippendorf the reason why Travis is failing, is because there's not a Travis file in this repository while it's required to merge. We can omit it.

Can you correct the formatting? See diff here on GitHub; probably spacing vs tab issue

hb9fxq commented 6 years ago

THX @johanstokking - Will fix formats in lunch break :-)

hb9fxq commented 6 years ago

@johanstokking done.

johanstokking commented 6 years ago

Looping in @kersing

These projects have diverged a bit unfortunately; just checking.

hb9fxq commented 6 years ago

Good idea, because I think that @kersing 's version https://github.com/kersing/packet_forwarder/blob/cb0f92f1c9a8bd85bf68da0328c2180c9d67dc71/mp_pkt_fwd/src/ttn_transport.c#L243 would drop lots of packages because it only matches rf powers in the txlut table. My version finds the max possible value in txlut table.

kersing commented 6 years ago

You might want to consider creating a patch for Lora-net/packet_forwarder. That repo is used by many vendors to create the software for their device. I've the MP source in current testing branch.

hb9fxq commented 6 years ago

@kersing OK, I will do that. This branch here is used by the ttn-zh GW used by lot of GWs here. TNX for the feedback. Will port it exactly like done here to Lora-net/packet_forwarder. Can you link the exact target branch to work towards?

@johanstokking this code here runs on my GWs and I can confirm it is working.

johanstokking commented 6 years ago

Thanks @krippendorf and @kersing.

Regarding https://github.com/Lora-net/packet_forwarder; all pull requests are open or closed, nothing gets merged there. Probably a licensing issue. Anyway, it may be worth reporting there and then hope it gets picked up and applied by the authors.