search

TheThingsArchive / python-app-sdk

The Things Network Application SDK for Python
MIT License
29 stars 16 forks source link

Added option to automatically reconnect client on MQTT disconnect #28

Closed gtmtg closed 6 years ago

gtmtg commented 6 years ago

Fixes #26

gtmtg commented 6 years ago

Of course! Is README.rst a legacy file or does it need to be updated too? Seems like mostly a duplicate of DOCUMENTATION.md...

egourlao commented 6 years ago

README.rst is being used by setuptools to generate documentation for pip. If I remember correctly, though, setuptools is also Markdown-compatible, so there should be a way to use DOCUMENTATION.md to avoid double work. I'll look into it tomorrow - if you don't want to wait, a copypaste should be enough :)

gtmtg commented 6 years ago

@dotpy3 Just updated both files! Question: I made the parameter default to False to preserve the original behavior, but I'm wondering if we should make it default to True instead? I feel like that may be expected behavior.

Also, re: using Markdown in setup.py, seems like you can just pass the Markdown file directly instead of the reStructuredText. See https://github.com/pypa/python-packaging-user-guide/blob/master/source/guides/distributing-packages-using-setuptools.rst#readme-rst-readme-md

gtmtg commented 6 years ago

@dotpy3 Bump on this!

egourlao commented 6 years ago

Let's go for setting it to True indeed, I think we can agree that this is the expected behaviour :)

gtmtg commented 6 years ago

Done! Sorry for the delay. Good to go?

egourlao commented 6 years ago

Looks great! Thank you for your contribution :)