Adding uplink_raw_callback function

TheThingsArchive / python-app-sdk

The Things Network Application SDK for Python

MIT License

29 stars 16 forks source link

Closed huebe closed 5 years ago

huebe commented 5 years ago

uplink_raw_callback function to:

Maintain compatibility with existing paho.mqtt.client implementations
Avoid unnecessary conversations to store the messages to nosql databases
- The existing DownlinkMessage.obj2json() function seems not to work all the time

egourlao commented 5 years ago

Looks good! Can you also add that to the documentation?

huebe commented 5 years ago

Documentation added. I couldn't add a test, because test_ttnmqtt.py seems to expect some kind of server running (on "localhost:1883").

huebe commented 5 years ago

Test added. Code, Documentation and Test are complete.

egourlao commented 5 years ago

Excellent, thank you! 🎉