TheThingsArchive / ttn

The Things Network Stack V2
https://www.thethingsnetwork.org
MIT License
461 stars 276 forks source link

Migrate to github.com/TheThingsNetwork/api #662

Closed htdvisser closed 7 years ago

htdvisser commented 7 years ago

We currently use github.com/TheThingsNetwork/ttn/api, but this is being moved to github.com/TheThingsNetwork/api.

In the process we are making some changes to the generated Go code in the new api package:

Please report any other improvements in https://github.com/TheThingsNetwork/api/issues

rvolosatovs commented 7 years ago

As far as I understand, packages like api/stats and api/ratelimit are not moved, or are they? Please specify concrete packages being moved

htdvisser commented 7 years ago

The packages that contain .proto files, as well as the fields package (renamed to logfields)

.
├── broker
├── discovery
├── gateway
├── handler
├── logfields
├── monitor
├── networkserver
├── protocol
│   └── lorawan
├── router
└── trace
rvolosatovs commented 7 years ago

what should happen with the Clients, i.e. monitor.Client ? I see they are not moved. Should we leave them in the same packages they are in now?

htdvisser commented 7 years ago

There are a number of things that will have to be moved to the new API package:

There are a number of things that will need a new place somewhere else:

Or have to be removed completely:

rvolosatovs commented 7 years ago

I will take care of that also then

htdvisser commented 7 years ago

Great! Nice to finally clean this mess up 😄