TheThingsArchive / ttn

The Things Network Stack V2
https://www.thethingsnetwork.org
MIT License
461 stars 276 forks source link

Changing an application's handler no longer warns that all devices will be lost #681

Closed ama9910 closed 6 years ago

ama9910 commented 6 years ago

What do you want to do? Improve communication to users

What steps did you take? Create application, register device, change to different hander, note that existing device no longer exists

What went wrong or what is missing? Warn user that devices will be deleted

Can you fix this yourself and submit a pull request? Unfortunately not

htdvisser commented 6 years ago

I assume this issue is related to the console?

ama9910 commented 6 years ago

Yes, Console On 14 Oct 2017, at 4:34 am, Hylke Visser notifications@github.com<mailto:notifications@github.com> wrote:

I assume this issue is related to the console?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/ttn/issues/681#issuecomment-336518312, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHHgLQFwYsl9cgnDDnuTJovP_x68pkB4ks5sr58XgaJpZM4P4CXr.

Andrew

romeovs commented 6 years ago

Do you see errors in the developer console? I've tested here on a couple of browsers and everything seems to work as expected.

ama9910 commented 6 years ago

Do you see errors in the developer console?

There are no errors associated with this issue.

everything seems to work as expected

How is the user notified that devices will be lost? All I see is the following message "Are you sure you want to change the handler registration for application .....? Confirm by typing the name of the application:"

romeovs commented 6 years ago

I see what you mean. I thought the issue was that you did not see this message. But the issue is that the message is not descriptive enough.

I'll fix it soon!

ama9910 commented 6 years ago

Thanks! FYI a previous console version would notify the user that devices configurations would be lost. I don't recall which version or what the message said.

htdvisser commented 6 years ago
screen shot 2017-11-03 at 10 04 32