TheThingsArchive / ttn

The Things Network Stack V2
https://www.thethingsnetwork.org
MIT License
461 stars 276 forks source link

Improper logging when the Broker NS token is invalid #690

Closed egourlao closed 6 years ago

egourlao commented 6 years ago

When a broker's NS token is invalid, rather than the component failing immediately, every request fails with a Warn:

broker_1         | 2017-12-18T22:36:22.572402949Z   WARN Could not handle uplink                  ADR=false ADRAckReq=false Ack=false AppPayloadSize=6 Confirmed=false DevAddr=46000607 DownlinkOptions=2 Duplicates=1 FCnt=1698 FPending=false FPort=2 PayloadSize=19 error=NetworkServer did not return devices: Unable to verify JWT: illegal base64 data at input byte 81 source=Wrap: /go/src/github.com/TheThingsNetwork/ttn/utils/errors/errors.go:222

The broker should fail immediately at startup, such as by a pre-reading of the JWT, like it does with the discovery server token.