TheThingsArchive / ttn

The Things Network Stack V2
https://www.thethingsnetwork.org
MIT License
461 stars 279 forks source link

In TTN Console, changing ABP device settings (even just its description) resets the frame counters #746

Closed avbentem closed 3 years ago

avbentem commented 5 years ago

This is a bug report for the console.

What do you want to do?

Change some settings of a device in TTN Console.

What steps did you take?

Changed the human-readable device's description. (Same goes for any other setting, including changing "Frame Counter Checks".)

What went wrong or what is missing?

Both the uplink and downlink frame counters were reset to zero, basically requiring the device to be reset.

If this is by design, then a warning should be shown.

The counters are not reset when using ttnctl rather than TTN Console.

Do you have Screenshots?

N/A.

What kind of OS/Browser/Gateway are you using? Which version?

N/A.

What are the IDs and EUIs of your Device/Gateway? (if applicable)

N/A.

What do your configuration files look like?

N/A.

What do your log files look like?

N/A.

Can you fix this yourself and submit a pull request?

No.

johanstokking commented 5 years ago

Thanks, we're adding some explanation in the V3 Console for this.

htdvisser commented 5 years ago

I can not reproduce this.

screen recording 2018-11-06 at 09 25 55 mov

avbentem commented 5 years ago

Hmmm, that's weird, I can really reproduce this every time; maybe it's specific to ABP?

github-ttn-746

(Sorry for the slow GIF... I'll try for OTAA too; to be continued.)

avbentem commented 5 years ago

@htdvisser Indeed, for me it's only happening with an ABP device. Not such a common problem after all then, though a warning might be nice...

(Using ttnctl for the very same ABP device does not reset the counters.)

htdvisser commented 3 years ago

This is not going to get fixed in V2 anymore.