Refactor ADR handling - Githubissues

TheThingsArchive / ttn

The Things Network Stack V2

https://www.thethingsnetwork.org

MIT License

461 stars 279 forks source link

Refactor ADR handling #758

Closed htdvisser closed 5 years ago

htdvisser commented 5 years ago

This Pull Request refactors ADR handling in the network server.

It removes the problematic loss calculation for NbTrans>1
It moves all ADR calculation to the uplink flow (similar to what we do in v3) and sets desired ADR parameters in the device model, as well as the SendReq flag.
The downlink flow now only looks at the SendReq flag, and generates the appropriate MAC commands

coveralls commented 5 years ago

Coverage increased (+0.06%) to 73.201% when pulling f57e96559a1097243765b3c6fb3f7797ffc0a03c on feature/adr into fd911b01ddadeb89d62d636fe61f7c13d83f9049 on develop.