This quickfix removes regex compilation on HEX decoding and data rate decoding. This is on the very hot path of networkserver, handler and broker.
Changes
Compile regex only once.
Replace regexp check from HEX decoder with length check.
Testing
Unit tests.
Notes for Reviewers
networkserver hot-path before
networkserver hot-path after
Checklist
[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
[ ] Documentation: Relevant documentation is added or updated.
[ ] Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
[x] Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.
Summary
This quickfix removes regex compilation on HEX decoding and data rate decoding. This is on the very hot path of
networkserver,handlerandbroker.Changes
Testing
Unit tests.
Notes for Reviewers
networkserverhot-path beforenetworkserverhot-path afterChecklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.